Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1422, Replace UT_DisplayPkt() with UtPrintx() #2269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Mar 29, 2023

Checklist

Describe the contribution

  • Fixes Replace UT_DisplayPkt with UtPrintx #1422
    • all instances of UT_DisplayPkt() replaced with UtPrintx()
    • the declaration and definition of UT_DisplayPkt() deleted
    • UT_DisplayPkt() turned into a simple macro that calls UtPrintx() and placed inside deprecation guards

Testing performed
GitHub CI actions (incl. Functional tests and Coverage Analysis etc.) all passing successfully.

Tested locally with standard cFS bundle tests - confirmed output text is correctly displayed and identical to before the change (the only difference other than the inclusion of the memory address, is the spacing and that the alphanumeric characters/digits in the hexadecimal output are now capitalized).

Before changes:
Screenshot 2023-03-29 12 54 25

After changes:
Screenshot 2023-03-29 12 54 19

Expected behavior changes
Test log prints now include the memory address along with the data.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.

Contributor Info
Avi Weiss @thnkslprpt

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration coding-standard. As part of the setup process, we have scanned this repository and found 1904 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration security. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.

@thnkslprpt thnkslprpt force-pushed the fix-1422-replace-ut-displaypkt-with-ut-printx branch from ec270a8 to bbbf8e6 Compare March 23, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace UT_DisplayPkt with UtPrintx
1 participant