Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #657, Add UT_Stub_RegisterContext to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog #673

Conversation

jtovias
Copy link
Contributor

@jtovias jtovias commented May 5, 2020

Add missing UT_Stub_RegisterContext to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog.
This will create the correct register buffer size.

Describe the contribution
Add missing UT_Stub_RegisterContext to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog.
This will create the correct register buffer size.

Testing performed
Steps taken to test the contribution:

travis CI passed: https://travis-ci.com/github/jtovias/cFS/builds/164052416

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

  • Behavior Change:
    • using ut stubs CFE_EVS_SendEvent and CFE_ES_WriteToSysLog, the register buffer will have the correct size
    • access to register buffer element will exist

System(s) tested on

  • Hardware:PC and UT700
  • OS: Centos 7 and VxWorks6.9
  • Versions: cFE 6.7.12.0, OSAL 5.0.11.0, PSP 1.4.8.0, chksm 9194

Additional context
None.

Third party code
None.

Contributor Info - All information REQUIRED for consideration of pull request
Jose Tovias/ CACI-LZT Technology/JSC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 6, 2020
@astrogeco
Copy link
Contributor

CCB 20200506 - APPROVED

@skliper skliper added CCB-20200506 CCB:PendingCLA External contribution pending CLA confirmation and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 6, 2020
@skliper
Copy link
Contributor

skliper commented May 7, 2020

@jtovias - could you fill out the remainder of the sections in the pull request template, and submit the Company CLA

@skliper
Copy link
Contributor

skliper commented May 7, 2020

Amend commit message -

Fix #657, Add unit test stub register context to cFE stubs

UT_Stub_RegisterContext added to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog

@skliper skliper changed the title fix657 add UT_Stub_RegisterContext Fix #657, Add UT_Stub_RegisterContext to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog May 7, 2020
@skliper skliper added this to the 6.8.0 milestone May 7, 2020
@jtovias
Copy link
Contributor Author

jtovias commented May 7, 2020

@skliper, if working for a NASA contract do I still need to submit a Company CLA?

@skliper
Copy link
Contributor

skliper commented May 7, 2020

@skliper, if working for a NASA contract do I still need to submit a Company CLA?

Yes, our office of patent counsel requires us to have a CLA for any contract other than our one local contract they have explicitly approved.

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label May 8, 2020
@skliper
Copy link
Contributor

skliper commented May 12, 2020

@jtovias Any status update/progress on the CLA?

@jtovias
Copy link
Contributor Author

jtovias commented May 12, 2020

@skliper I email my CLA for cFE 6.7 and OSAL Thursday (5/7) to GSFC-SoftwareRelease gsfc-softwarerelease@mail.nasa.gov. Am I suppose to get an email confirmation?

@skliper
Copy link
Contributor

skliper commented May 12, 2020

@jtovias Thanks! I'll confirm it was received.

Integration Candidate COMBINED 2020-04-29 and 2020-05-06
@astrogeco
Copy link
Contributor

@jtovias Thanks! I'll confirm it was received.

@skliper any update on this CLA?

Add missing UT_Stub_RegisterContext to CFE_EVS_SendEvent and CFE_ES_WriteToSysLog.
This will create the correct register buffer size.
@skliper skliper force-pushed the fix657-add-UT-Stub-RegisterContext branch from c5f6456 to 84e10c5 Compare May 19, 2020 16:41
@skliper
Copy link
Contributor

skliper commented May 19, 2020

Rebased on master and updated commit message. Still pending OPC CLA confirmation.

@skliper skliper removed the CCB:PendingCLA External contribution pending CLA confirmation label May 19, 2020
@skliper
Copy link
Contributor

skliper commented May 19, 2020

@astrogeco CLA receipt confirmed.

@astrogeco astrogeco changed the base branch from master to integration-candidate May 19, 2020 20:30
@astrogeco
Copy link
Contributor

@skliper looks like something broke in the CI config.

@astrogeco astrogeco changed the base branch from integration-candidate to master May 19, 2020 21:00
@skliper
Copy link
Contributor

skliper commented May 20, 2020

@astrogeco - I just restarted the test and it worked fine. Looked like a travis-ci issue (not an issue on our side).

@astrogeco astrogeco changed the base branch from master to integration-candidate May 20, 2020 13:06
@astrogeco astrogeco merged commit 5727781 into nasa:integration-candidate May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing registering contexts in stub functions
4 participants