Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lgtm c issues #43

Closed
avan989 opened this issue Dec 17, 2019 · 1 comment · Fixed by #92 or #101
Closed

lgtm c issues #43

avan989 opened this issue Dec 17, 2019 · 1 comment · Fixed by #92 or #101
Assignees
@skliper
Labels
bug Something isn't working
Milestone
Bootes

Comments

@avan989
Copy link
Contributor

avan989 commented Dec 17, 2019 •
edited by lbleier-GSFC
Loading

Describe the bug
Issues report from LGTM.

SendUdp.h
This header file should contain a header guard to prevent multiple inclusion.

cmdUtil.c:

 line - 213, 254, 274, 293, 318, 339
void ProcessStringArgument(char *optarg, CommandData_t *CommandData) {
--
  | Parameter CommandData hides a global variable with the same name.

cmdUtil.c

line 62 -84
Struct struct <unnamed> has 16 fields; we suggest refactoring to 15 fields or fewer.

To Reproduce
Steps to reproduce the behavior:

  1. Build against Lgtm

Reporter Info
Anh Van, NASA Goddard
@skliper skliper added the enhancement New feature or request label Mar 16, 2020
@lbleier-GSFC
Copy link
Contributor

This issue has been updated to be C-related only; Python issues have been consolidated into issue #46

@lbleier-GSFC lbleier-GSFC mentioned this issue Apr 13, 2020
Closed
@skliper skliper changed the title lgtm issues lgtm c issues Apr 13, 2020
skliper added a commit to skliper/cFS-GroundSystem that referenced this issue May 21, 2020
@skliper
Fix nasa#43, Resolve LGTM issues
238b772 
Added header guard
Removed local parameter hiding global
@skliper skliper mentioned this issue May 21, 2020
Merged
6 tasks
skliper added a commit to skliper/cFS-GroundSystem that referenced this issue May 21, 2020
@skliper
Fix nasa#43, Resolve LGTM issues
a959171 
Added header guard
Removed local parameter hiding global
@skliper skliper self-assigned this May 21, 2020
skliper added a commit to skliper/cFS-GroundSystem that referenced this issue May 26, 2020
@skliper
Fix nasa#43, Resolve LGTM issues
dae41fa 
Added header guard
Removed local parameter hiding global
@astrogeco astrogeco mentioned this issue Jun 9, 2020
Merged
@astrogeco astrogeco added bug Something isn't working and removed enhancement New feature or request labels Oct 1, 2020
@astrogeco astrogeco added this to the 2.2.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
bug Something isn't working
Projects
None yet
Milestone
Bootes
4 participants
@avan989 @skliper @astrogeco @lbleier-GSFC