Fix nasa#43, Resolve LGTM issues

Added header guard Removed local parameter hiding global
skliper · May 23, 2020 · dae41fa · dae41fa
1 parent 3de6e98
commit dae41fa
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 23 deletions.
diff --git a/Subsystems/cmdUtil/SendUdp.h b/Subsystems/cmdUtil/SendUdp.h
@@ -17,4 +17,9 @@
 **      See the License for the specific language governing permissions and
 **      limitations under the License.
 */
+#ifndef _sendudp_
+#define _sendudp_
+
 int SendUdp(char *hostname, char *portNum, char *packetData, int packetSize);
+
+#endif /* _sendudp_ */
diff --git a/Subsystems/cmdUtil/cmdUtil.c b/Subsystems/cmdUtil/cmdUtil.c
@@ -80,8 +80,7 @@ typedef struct
 /*
 ** Declare the global command data
 */
-CommandData_t CommandData;
-int           hostByteOrder;
+int hostByteOrder;
 
 /*
 ** getopts parameter passing options string
@@ -397,6 +396,7 @@ int main(int argc, char *argv[])
     int            longIndex = 0;
     int            retStat;
     unsigned short tempShort;
+    CommandData_t  CommandData;
 
     /*
     ** Initialize the CommandData struct

diff --git a/Subsystems/cmdUtil/cmdUtil.sln b/Subsystems/cmdUtil/cmdUtil.sln