Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #202, fix variable name errors in tlmGUI #203

Closed
wants to merge 1 commit into from
Closed

Fix #202, fix variable name errors in tlmGUI #203

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2022

Describe the contribution
Fixed variable name errors that were missed in a previous conversion. The errors would not allow the generic telemetry page GUI to work.

Testing performed
Before the variables were renamed, opening a generic subsystem telemetry page would result in a python error:
NameError: name 'tlm_item_desc' is not defined

After the variables were renamed, the generic subsystem telemetry page comes up as it should, and displays telemetry from the cFS.

Expected behavior changes

  • Or no impact to behavior

System(s) tested on

  • Hardware: x86 PC and VM
  • OS: Ubuntu 18.04 and Ubuntu 20.04
  • Versions: cFS-GroundSystem v3.0.0-rc4+dev7 (main branch)

Additional context
None

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Alan Cudmore / NASA Goddard Space Flight Center

@ghost ghost added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jan 27, 2022
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Feb 2, 2022
@skliper
Copy link
Contributor

skliper commented Apr 20, 2022

@astrogeco @acudmore - what's the status on this? Missing documentation as to why CCB:Ready was removed or what the path to closure is.

@astrogeco
Copy link
Contributor

We renamed in the wrong "direction" so we ended up dropping it from the CCB agenda.

@skliper skliper added the CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB. label Apr 20, 2022
@skliper
Copy link
Contributor

skliper commented Apr 20, 2022

Added ignore label until this is fixed to update in the right direction or is closed/replaced.

@ghost ghost closed this by deleting the head repository Aug 31, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Ignore Pull Request is NOT ready for discussion. Has open actions. Will be re-examined at by next CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants