Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage for shared dropped below 100% (again) #602

Closed
skliper opened this issue Sep 22, 2020 · 0 comments · Fixed by #768 or #774
Closed

Code coverage for shared dropped below 100% (again) #602

skliper opened this issue Sep 22, 2020 · 0 comments · Fixed by #768 or #774
Assignees
@jphickey
Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Sep 22, 2020

Is your feature request related to a problem? Please describe.
shared/src/osapi-common.c: OS_DeleteAllObjects missing coverage
shared/src/osapi-idmap.c: OS_ObjectIdFinalizeDelete not covered

Describe the solution you'd like

  1. Add coverage back in
  2. Enforce 100% coverage in CI

Describe alternatives you've considered
At minimum add coverage back... CI really should enforce or we will keep missing code coverage.

Additional context
None.

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper changed the title Code coverage for shared and vxworks dropped below 100% (again) Code coverage for shared dropped below 100% (again) Sep 22, 2020
@skliper skliper mentioned this issue Sep 22, 2020
Merged
@skliper skliper added this to the 6.0.0 milestone Sep 22, 2020
@skliper skliper added the unit-test Tickets related to the OSAL unit testing (functional and/or coverage) label Sep 30, 2020
@skliper skliper assigned jphickey and unassigned zanzaben Jan 6, 2021
jphickey added a commit to jphickey/osal that referenced this issue Jan 22, 2021
@jphickey
Fix nasa#602, bring OSAL code coverage back up to 100%
bebeb70 
Adds test cases where necessary to get 100% line coverage
on VxWorks impl + shared/portable layers.
@jphickey jphickey mentioned this issue Jan 22, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue Jan 27, 2021
@jphickey
Fix nasa#602, bring OSAL code coverage back up to 100%
e77e657 
Adds test cases where necessary to get 100% line coverage
on VxWorks impl + shared/portable layers.
astrogeco added a commit that referenced this issue Feb 3, 2021
@astrogeco
Merge pull request #768 from jphickey/fix-602-codecoverage
1ebb788 
Fix #602, bring OSAL code coverage back up to 100%
@astrogeco astrogeco mentioned this issue Feb 12, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue Aug 10, 2022
@jphickey
Merge pull request nasa#602 and nasa#635
3b7f20f 
Manually merged to resolve conflicts.

From branch jphickey/fix-263-msgid-api:

Fix nasa#245, Consistent use of MsgId type
Fix nasa#263, Expose CFE_SB_IsValidMsgId() API

From branch dmknutsen/issue_240:

Fixes nasa#240, removes MESSAGE_FORMAT_IS_CCSDS ifdefs from code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement unit-test Tickets related to the OSAL unit testing (functional and/or coverage)
Projects
None yet
Milestone
Caelum
4 participants
@zanzaben @jphickey @skliper @astrogeco