Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #602, bring OSAL code coverage back up to 100% #768

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

jphickey
Copy link
Contributor

Describe the contribution
Adds test cases where necessary to get 100% line coverage on VxWorks implementation + shared/portable layers.

Fixes #602

Testing performed
Build CFE with unit tests
Run all unit tests and check coverage report (FSW not affected)

Expected behavior changes
No impact to OSAL implementation - only affects coverage tests.
Coverage testing is now back at 100% functions + 100% lines.

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jan 22, 2021
astrogeco and others added 2 commits January 26, 2021 23:19
osal Integration candidate: 2021-01-19
Adds test cases where necessary to get 100% line coverage
on VxWorks impl + shared/portable layers.
@jphickey
Copy link
Contributor Author

Rebased to newest "main" branch, resolved conflicts.

@astrogeco astrogeco added CCB:2021-01-27 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jan 27, 2021
@astrogeco
Copy link
Contributor

CCB 2021-01-27 APPROVED

Adds missing prototypes to headers
Exercises insufficiently covered if branches

@astrogeco astrogeco changed the base branch from main to integration-candidate January 27, 2021 22:08
@astrogeco astrogeco merged commit 1ebb788 into nasa:integration-candidate Feb 3, 2021
@jphickey jphickey deleted the fix-602-codecoverage branch April 28, 2021 18:58
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code coverage for shared dropped below 100% (again)
3 participants