Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some "close" operations not doing standard delete procedure #647

Closed
jphickey opened this issue Nov 10, 2020 · 0 comments · Fixed by #666
Closed

Some "close" operations not doing standard delete procedure #647

jphickey opened this issue Nov 10, 2020 · 0 comments · Fixed by #666
Assignees
Labels
Milestone

Comments

@jphickey
Copy link
Contributor

Describe the bug
All close/delete ops should go through OS_FinalizeDelete() so things are cleaned up consistently.
But there remain a couple places where this is not done - OS_close() and its variants e.g. OS_CloseFileByName and OS_CloseAllFiles

To Reproduce
This is apparent if there is some action in the PSP handler for deallocation. It will not get invoked for these close ops because it doesn't go through the common delete path.

Expected behavior
Should go through common path.

System observed on:
Ubuntu 20.04

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Nov 10, 2020
@jphickey jphickey added the bug label Nov 10, 2020
@jphickey jphickey linked a pull request Dec 3, 2020 that will close this issue
@skliper skliper closed this as completed Feb 16, 2021
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
Fix nasa#523, SB Subscription report control on separate MID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants