Fix #522 - SocketOpen stub should set sock_id

[CDKnightNASA]

Describe the contribution
Fix #522 - OS_SocketOpen() should, on "success", set sock_id and return a status.

Additional context
See OS_SocketOpen() definition in

osal/src/os/inc/osapi-os-net.h

Line 232 in bc73437

* @param[out] sock_id Buffer to hold the non-zero OSAL ID

Contributor Info - All information REQUIRED for consideration of pull request
Christopher.D.Knight@nasa.gov

[skliper]

Missing explicit keywords to autolink with issue. Either use them (Fix #xxx) or link by hand to issue.

[CDKnightNASA]

Missing explicit keywords to autolink with issue. Either use them (Fix #xxx) or link by hand to issue.

Weird, if you look at the text of the PR, it has an autolink (hover over #522 above). Why it doesn't link it under linked issues is beyond me. :/

[jphickey]

Weird, if you look at the text of the PR, it has an autolink (hover over #522 above). Why it doesn't link it under linked issues is beyond me. :/

A simple text reference like "#522" will result in a clickable hyperlink but github does not assume that this PR will fix/close that issue unless you actually say "Fixes #522" or one of the other specific closing keywords. (not "Fix for").

See https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

[astrogeco]

CCB-20200624: Approved