Integration Candidate: 2020-04-15 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not clobber the CMAKE_C_FLAGS value as part of the OSAL build. Instead, use target_compile_options and target_include_directories as needed to set the compile options for specific targets. This also creates a separate CMakeLists.txt file for each OS/BSP implementation library rather than using aux_source_directory. Each implementation-specific build can then set any additional options as required for that platform. Note that any entity needing to compile/link with OSAL should now obtain the requisite compile flags and directories by querying the INTERFACE_COMPILE_DEFINITIONS and INTERFACE_INCLUDE_DIRECTORIES properties on the osal library target.
Refactor the OSAL BSP code so that a single BSP implementation can work for both normal applications as well as unit tests. This intoduces a new bsp implementation abstraction layer akin to the low level OS implementation layer. This handles dealing with bootloader/command line arguments, and debug console manipluation.
Build the full suite of OSAL coverage tests as part of the normal build when ENABLE_UNIT_TESTS is true. This will use the same target OSAL BSP to execute the tests as is used for the FSW.
This ensures that the return value of the write() call is checked, and avoids a potential compiler warning. There is still no recourse if the write call fails, but it can retry if it was short.
Fix #397, Remove old unit test example, add README.md, further macro cleanup
Fix #232, pthread stack min typo
Avoids calling write() if length is zero.
astrogeco
changed the title
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Removed conflicting files, not needed after nasa#417 changes.
jphickey
pushed a commit
to jphickey/osal
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #232, #397, #312, #261, #362, and #363
See Bundle IC at nasa/cFS#66
Testing performed
See PRs
Bundle CI - https://travis-ci.com/github/nasa/cFS/builds/160607248
Expected behavior changes
System(s) tested on
See PRs
Bundle CI - Ubuntu:Bionic
Contributor Info - All information REQUIRED for consideration of pull request
Christopher D. Knight, NASA-ARC
Joseph Hickey, Vantage Systems, Inc.
David Archuleta Jr., Self
Gerardo E. Cruz-Ortiz - NASA-GSFC