Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous PR #45 broke some platforms due to type mismatch #47

Closed
jphickey opened this issue Jun 26, 2020 · 0 comments · Fixed by #48 or #53
Closed

Previous PR #45 broke some platforms due to type mismatch #47

jphickey opened this issue Jun 26, 2020 · 0 comments · Fixed by #48 or #53
Labels
bug Something isn't working
Milestone

Comments

@jphickey
Copy link
Contributor

Describe the bug
A recent change in pull request #45 changed the TO_LAB_init function prototype to return an int32 type here:

int32 TO_LAB_init(void);

However the function is actually defined later here:

int TO_LAB_init(void)

This results in error if int and int32 are not actually the same type.

To Reproduce
Build on any platform where int and int32 are not the same type (e.g. 32 bit RTEMS, for example).

Expected behavior
Declaration should match definition, and it should build cleanly.

System observed on:
RTEMS 4.11.3 (cross)

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the bug Something isn't working label Jun 26, 2020
CDKnightNASA added a commit to CDKnightNASA/to_lab that referenced this issue Jun 26, 2020
astrogeco added a commit that referenced this issue Jul 2, 2020
fix #47 - correct return type for TO_LAB_init()
astrogeco pushed a commit to astrogeco/to_lab that referenced this issue Aug 4, 2020
@astrogeco astrogeco added this to the 2.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants