Integration Candidate 2020-07-29 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reset version numbers to last release. Added build number and baseline macros. Added and using version string instead of number macros in reporting.
Close #49, Add build number and baseline to version file
astrogeco
force-pushed
the
integration-candidate
branch
3 times, most recently
from
01b4686
to
e94a3e4
Compare
Set "development build" part of version string to ALL CAPS for readability
astrogeco
force-pushed
the
integration-candidate
branch
from
e94a3e4
to
a4d06c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #47
Fix #50
Close #49
Testing performed
Bundle CI - https://github.com/nasa/cFS/pull/119/checks
Expected behavior changes
PR #48 - Corrects return value of TO_LAB_init() to be int32 not int.
PR #51 - Fixes bug where an unset address values caused subscriptions to MsgId 0 over 200 times. Added a TO_UNUSED entry at the end of the subscription list and a break in the subscription loop when TO_UNUSED found. No more subscriptions on the unused table slots (no MsgId 0 subscriptions).
PR #52 - Add build number and baseline
System(s) tested on
Ubuntu
Additional context
Part of nasa/cFS#119
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman, NASA-GSFC
Gerardo E. Cruz-Ortiz, NASA-GSFC
Christopher D. Knight, NASA-ARC