Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): widget layer dropdown & translation [EP-3654] #403

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

dan-qc
Copy link
Contributor

@dan-qc dan-qc commented Jan 6, 2021

All boxes should be checked before the PR can be accepted. Exceptions can be made, but they need to be argumented and discussed with the reviewer


STORY

Required

  • Added QA classes on main containers and all actionable items like Buttons, Inputs, etc
  • Translated all the user facing text (static & dynamic)
  • Ran Unit Tests and they pass successfuly
  • Added unit tests for the code in earth-shared
  • Ran the linter with yarn lint
  • No TypeScript warnings are introduced
  • I have made corresponding changes to the documentation

Not Needed

  • Drag here



BUGFIX

Required

  • Translated all the user facing text (static & dynamic)
  • Ran Unit Tests and they pass successfuly
  • Ran the linter with yarn lint
  • No TypeScript warnings are introduced

Not Needed

  • Drag here
  • I have made corresponding changes to the documentation



References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

@dan-qc dan-qc requested a review from ancashoria January 6, 2021 08:38
@dan-qc dan-qc merged commit 234fa0b into develop Jan 6, 2021
@dan-qc dan-qc deleted the bug/EP-3654 branch January 6, 2021 10:17
genodeploy pushed a commit that referenced this pull request Jan 12, 2021
## [1.16.3](v1.16.2...v1.16.3) (2021-01-12)

### Bug Fixes

* **admin:** dashboard widgets empty value [EP-3658] ([#410](#410)) ([674b45d](674b45d))
* **admin:** email component reset state [EP-3299] ([#422](#422)) ([0d3e5a4](0d3e5a4))
* **admin:** filter collection on intersections [EP-3653] ([#407](#407)) ([502c655](502c655))
* **admin:** loading indicator when performing delete [EP-2592] ([#412](#412)) ([f19818f](f19818f))
* **admin:** primary button font color [EP-3160] ([#423](#423)) ([a739ef9](a739ef9))
* **admin:** reset server error when switching geojson tabs [EP-3652] ([#429](#429)) ([b30cf79](b30cf79))
* **admin:** update org-switcher context on editing org owners [EP-3671] ([ed32c14](ed32c14))
* **admin:** update org-switcher context on org update [EP-3402] ([c47d889](c47d889))
* **admin:** widget layer dropdown & translation [EP-3654] ([#403](#403)) ([234fa0b](234fa0b))
* **map:** Fix app crash when deleting a selected org [EP-3333] ([6830a0c](6830a0c))
* **map:** layers subheader [EP-3657] ([#408](#408)) ([e0a114c](e0a114c))
* **map:** left panel remove shadow [EP-3268] ([#427](#427)) ([5415dc6](5415dc6))
* **map:** remove last viewed place when unavailable [EP-2272] ([#426](#426)) ([643cd55](643cd55))
* **map:** Removed places and layers from Session Storage [EP-3605] ([aef4002](aef4002))
* Fix multiselect search [EP-3625] ([0b3c1db](0b3c1db))
@dan-qc
Copy link
Contributor Author

dan-qc commented Jan 12, 2021

🎉 This PR is included in version 1.16.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants