fix(map): remove last viewed place when unavailable [EP-2272] #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancashoria
reviewed
Jan 11, 2021
| } = yield select(getAll); | ||
|
|
||
| if (lastViewedPlace?.slug === slug) { | ||
| yield put(setLastViewedPlace(null)); |
There was a problem hiding this comment.
You should probably yield put(persistData());to also change the session storage
ancashoria
approved these changes
Jan 12, 2021
genodeploy
pushed a commit
that referenced
this pull request
Jan 12, 2021
## [1.16.3](v1.16.2...v1.16.3) (2021-01-12) ### Bug Fixes * **admin:** dashboard widgets empty value [EP-3658] ([#410](#410)) ([674b45d](674b45d)) * **admin:** email component reset state [EP-3299] ([#422](#422)) ([0d3e5a4](0d3e5a4)) * **admin:** filter collection on intersections [EP-3653] ([#407](#407)) ([502c655](502c655)) * **admin:** loading indicator when performing delete [EP-2592] ([#412](#412)) ([f19818f](f19818f)) * **admin:** primary button font color [EP-3160] ([#423](#423)) ([a739ef9](a739ef9)) * **admin:** reset server error when switching geojson tabs [EP-3652] ([#429](#429)) ([b30cf79](b30cf79)) * **admin:** update org-switcher context on editing org owners [EP-3671] ([ed32c14](ed32c14)) * **admin:** update org-switcher context on org update [EP-3402] ([c47d889](c47d889)) * **admin:** widget layer dropdown & translation [EP-3654] ([#403](#403)) ([234fa0b](234fa0b)) * **map:** Fix app crash when deleting a selected org [EP-3333] ([6830a0c](6830a0c)) * **map:** layers subheader [EP-3657] ([#408](#408)) ([e0a114c](e0a114c)) * **map:** left panel remove shadow [EP-3268] ([#427](#427)) ([5415dc6](5415dc6)) * **map:** remove last viewed place when unavailable [EP-2272] ([#426](#426)) ([643cd55](643cd55)) * **map:** Removed places and layers from Session Storage [EP-3605] ([aef4002](aef4002)) * Fix multiselect search [EP-3625] ([0b3c1db](0b3c1db))
|
🎉 This PR is included in version 1.16.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All boxes should be checked before the PR can be accepted. Exceptions can be made, but they need to be argumented and discussed with the reviewer
STORY
Required
yarn lintNot Needed
BUGFIX
Required
yarn lintNot Needed
References
By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.