Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profile) - add country and institution fields #440

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

vt90
Copy link
Contributor

@vt90 vt90 commented Jan 20, 2021

Signed-off-by: Vlad Tomsa tomsavlad90@gmail.com

All boxes should be checked before the PR can be accepted. Exceptions can be made, but they need to be argumented and discussed with the reviewer


STORY

Required

  • Added QA classes on main containers and all actionable items like Buttons, Inputs, etc
  • Translated all the user facing text (static & dynamic)
  • Ran Unit Tests and they pass successfuly
  • Ran the linter with yarn lint
  • No TypeScript warnings are introduced

Not Needed

  • Added unit tests for the code in earth-shared
  • I have made corresponding changes to the documentation

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>
@vt90 vt90 requested a review from ancashoria January 20, 2021 16:58
@vt90 vt90 merged commit aafd6c2 into develop Jan 21, 2021
@vt90 vt90 deleted the EP-3682-update-profile-fields branch January 21, 2021 16:31
dan-qc added a commit that referenced this pull request Jan 27, 2021
* feat(map) - update legend container max-height to be aligned with the search-box [EP-3645] (#442)

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* feat(profile) - add country and institution fields (#440)

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* Ep 3679 add institution and country to sign up form (#441)

* feat(auth) - add new fields to sign-up screen

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* fix(auth) - update sign up styling

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* feat(auth) - add new fields to sign-up screen

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* fix(auth) - update sign up styling

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* feat(auth) - use country list provided by the API

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* fix(auth) - remove shared country list

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* feat(auth) - update country select styling

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* fix(auth) - code refactor

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* feat(auth) - update dropdown styles

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* fix(map): weglot gatsby integration [EP-3710] (#445)

* feat(map): Set page background to dark [EP-3281]

* fix(marapp-admin): exclude edited layer from included layers dropdown [EP-3676]

* wip

* feat(map): support SWR on selected location [EP-3709]

Co-authored-by: Vlad Tomsa <tomsavlad90@gmail.com>
Co-authored-by: Horia Miron <horia.ancas@gmail.com>
Co-authored-by: Horia Iacos <iacos.horia@gmail.com>
@dan-qc
Copy link
Contributor

dan-qc commented Jan 28, 2021

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants