Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ep 3709 create custom hooks location #456

Merged

Conversation

dan-qc
Copy link
Contributor

@dan-qc dan-qc commented Jan 27, 2021

All boxes should be checked before the PR can be accepted. Exceptions can be made, but they need to be argumented and discussed with the reviewer


STORY

Required

  • Added QA classes on main containers and all actionable items like Buttons, Inputs, etc
  • Translated all the user facing text (static & dynamic)
  • Ran Unit Tests and they pass successfuly
  • Added unit tests for the code in earth-shared
  • Ran the linter with yarn lint
  • No TypeScript warnings are introduced
  • I have made corresponding changes to the documentation

Not Needed

  • Drag here



BUGFIX

Required

  • Translated all the user facing text (static & dynamic)
  • Ran Unit Tests and they pass successfuly
  • Ran the linter with yarn lint
  • No TypeScript warnings are introduced
  • I have made corresponding changes to the documentation

Not Needed

  • Drag here



References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

By submitting a PR to this repository, you agree to the terms within the Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

vt90 and others added 10 commits January 21, 2021 18:30
… search-box [EP-3645] (#442)

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>
Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>
* feat(auth) - add new fields to sign-up screen

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* fix(auth) - update sign up styling

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* feat(auth) - add new fields to sign-up screen

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* fix(auth) - update sign up styling

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* feat(auth) - use country list provided by the API

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* fix(auth) - remove shared country list

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* feat(auth) - update country select styling

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* fix(auth) - code refactor

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>

* feat(auth) - update dropdown styles

Signed-off-by: Vlad Tomsa <tomsavlad90@gmail.com>
…s-exclude

fix(admin): exclude edited layer from included layers dropdown
@dan-qc dan-qc changed the base branch from develop to EP-3709-create-custom-hooks January 27, 2021 12:27
@dan-qc dan-qc merged commit d6b6f79 into EP-3709-create-custom-hooks Jan 27, 2021
@dan-qc dan-qc deleted the feat/EP-3709-create-custom-hooks-location branch January 27, 2021 12:49
@dan-qc
Copy link
Contributor Author

dan-qc commented Jan 28, 2021

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants