-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests draft #100
base: master
Are you sure you want to change the base?
Unit tests draft #100
Conversation
@aileo Hi, apologies for taking a while to get to this, I've taken some time off this project to work on a couple of other things - and work is busy at the moment. :) I tried this PR, and it's awesome! I wanted to add unit tests but never gotten round to it, so it's awesome you did this! To be honest, I'm perfectly happy merging this as is - it works great, tests pass, and it adds a lot to the project. The only thing is that when I run |
Very nice tchoo-tchoo videos :)
I'm happy if you're happy :D |
I decided to have some fun and actually write some code that uses this library for once. ;)
I think that's a great idea. Perhaps one output device and one input device as a demonstration of both? I think Hub Button and Hub LED would both be good candidates for this. |
- improve sent message check - remove temperature subscription test on technicmediumhub - replace equal by strictEqual due to deprecation
Hi, sorry for the delay, I finally got back on this lib.
I wrote tests for the HubLED Device but the Hub buttons are not devices so I will go for the remotecontrolbutton instead. |
Attempt to create a test suite to check logic without physical devices.
Also fix
_requestHubPropertyValue
so it will reject if_parseHubPropertyResponse
throws.