Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables use of Pwr_Limit_Bat_Dn on H1 G2 #667

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Disables use of Pwr_Limit_Bat_Dn on H1 G2 #667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3712616
Disables use of Pwr_Limit_Bat_Dn on H1 G2
FozzieUK Aug 27, 2024
e1feb27
Update remote_control_description.py
FozzieUK Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion custom_components/foxess_modbus/entities/remote_control_description.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
max_soc=41010,
invbatpower=[31022],
battery_soc=[31024],
pwr_limit_bat_up=[44012],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind just adding a comment with a link to the discussion where we discovered this? Or I'm happy to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry should have added that 😊

As discussed in this thread #666 (reply in thread)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, I meant to the code. I'd do it myself, but you need to tick the little box allowing other people to make changes to the PR

pwr_limit_bat_up=None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pwr_limit_bat_up=None,
# Exists, but see https://github.com/nathanmarlor/foxess_modbus/discussions/666
pwr_limit_bat_up=None,

pv_voltages=[39070, 39072],
),
models=Inv.H1_G2,
Expand All @@ -70,6 +70,7 @@
invbatpower=[11008],
battery_soc=[11036],
pwr_limit_bat_up=None,
# Exists, but see https://github.com/nathanmarlor/foxess_modbus/discussions/666
pv_voltages=[11000, 11003, 11096, 11099],
),
models=Inv.KH_PRE119,
Expand Down
Loading