Simplify Request(), allow for mux subject to possibly change. #523
Conversation
go.mod
Outdated
| @@ -1,7 +1,9 @@ | |||
| module github.com/nats-io/nats.go | |||
|
|
|||
| require ( | |||
| github.com/nats-io/jwt v0.2.12 | |||
| github.com/golang/protobuf v1.3.2 | |||
There was a problem hiding this comment.
This is a pain.. the server has the client in its deps (which arguably should not if it was not for the server tests) and if we have the client have the server in its deps we will always have say Server 2.1.0 depends on client 1.8.1, then client 1.9.0 depends on say server 2.1.0, etc.. so older nats client or server versions will be pulled.. We really need to figure that out because manually cleaning this file is no joy.
There was a problem hiding this comment.
And the answer maybe that we "don't care" that there are those inter-deps?
There was a problem hiding this comment.
I try to fix them, must have done a test before last push. One sec.
There was a problem hiding this comment.
ok take a look now.
|
I will squash down and merge when green. |
Signed-off-by: Derek Collison <derek@nats.io>
PR #523 introduced and issue that could cause a Request() call to receive a reply that was intended for another Request() call if the responder sent multiple replies for the same request. This issue is only in v1.9.0 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Derek Collison derek@nats.io