Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Request() may receive invalid reply if responder sends multiple replies #528

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

kozlovic
Copy link
Member

PR #523 introduced and issue that could cause a Request() call
to receive a reply that was intended for another Request() call
if the responder sent multiple replies for the same request.

This issue is only in v1.9.0

Signed-off-by: Ivan Kozlovic ivan@synadia.com

PR #523 introduced and issue that could cause a Request() call
to receive a reply that was intended for another Request() call
if the responder sent multiple replies for the same request.

This issue is only in v1.9.0

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic changed the title [FIXED] Request() may receive invalid reply if reponser send multiples [FIXED] Request() may receive invalid reply if responder sends multiple replies Oct 31, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.995% when pulling a3c7525 on fix_multiple_replies into 41e7eae on master.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kozlovic kozlovic merged commit 6063d67 into master Oct 31, 2019
@kozlovic kozlovic deleted the fix_multiple_replies branch October 31, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants