Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBF will block the main thread for an arbitrary time when canceling an execution #323

Open
corot opened this issue Jul 21, 2023 · 0 comments

Comments

@corot
Copy link
Collaborator

corot commented Jul 21, 2023

Because we join its thread after cancelling an execution. This is dangerous because we relay on plugins cancel implementation to finish properly. And meanwhile we won't have callbacks, so for example a controller slowing down on cancel won't get an updated velocity from MBF.

UPDATE After #345, this problem won't happen if the old and new goals have the same controller. In that case, we will preempt the previous goal instead of canceling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant