Flexible via specification for xform_brain / shortest_bridging_seq #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* works ok * still doesn't solve all issues with FAFB14um node * still feels like we need special handling of scaling transforms (should effectively have weight 0 or minimally reciprocal edge weight 0)
* relax tests to reflect presence of vpath attribute
* sometimes you want to come back to the sample spave via a given brain
* revealed by recursive calls to shortest_bridging_seq
* NB this effectively retires the bridging_sequence option in favour of shortest_bridging_seq in all situations * note that bridging_sequence required all via steps to be specified * also prints messages about selected path for transformation
* much more extensive testing * note that I factored out a small function to avoid repeatedly constructing the bridging graph * this is also simplified combining paths across the graph
* r cmd check on travis complained
This was referenced Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case
viadoes not have to specify the complete path from sample to reference. This means that it can be used to insist on a particular set of registrations when a range of paths are possible. See #44