LTM: Deprecates Python 3.7 (#143)

* deprecates Python 3.7 * add py311 support --------- Co-authored-by: Jeff Kala <jeff.l.kala@gmail.com>
nautobot · Mar 13, 2024 · 2dd5a7b · 2dd5a7b
1 parent 964bade
commit 2dd5a7b
Show file tree

Hide file tree

Showing 8 changed files with 36 additions and 248 deletions.
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -4,8 +4,8 @@ about: Report a reproducible bug in the current release of nautobot-plugin-norni
 ---
 
 ### Environment
-* Python version:  <!-- Example: 3.7.7 -->
-* Nautobot version:  <!-- Example: 1.0.1 -->
+* Python version:  <!-- Example: 3.8.3 -->
+* Nautobot version:  <!-- Example: 1.6.1 -->
 * nautobot-plugin-nornir version:  <!-- Example: 1.0.0 -->
 
 <!--

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -83,7 +83,7 @@ jobs:
       fail-fast: true
       matrix:
         python-version: ["3.8"]
-        nautobot-version: ["1.4.0"]
+        nautobot-version: ["1.6.1"]
     env:
       INVOKE_NAUTOBOT_PLUGIN_NORNIR_PYTHON_VER: "${{ matrix.python-version }}"
       INVOKE_NAUTOBOT_PLUGIN_NORNIR_NAUTOBOT_VER: "${{ matrix.nautobot-version }}"
@@ -119,19 +119,19 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        python-version: ["3.7", "3.8", "3.9", "3.10"]
+        python-version: ["3.8", "3.9", "3.10", "3.11"]
         db-backend: ["postgresql"]
-        nautobot-version: ["stable"]
+        nautobot-version: ["1.6.1"]
         include:
-          - python-version: "3.10"
+          - python-version: "3.11"
             db-backend: "postgresql"
-            nautobot-version: "1.4.0"
-          - python-version: "3.7"
+            nautobot-version: "1.6.1"
+          - python-version: "3.8"
             db-backend: "mysql"
-            nautobot-version: "1.4.0"
-          - python-version: "3.10"
+            nautobot-version: "1.6.1"
+          - python-version: "3.11"
             db-backend: "mysql"
-            nautobot-version: "stable"
+            nautobot-version: "1.6.1"
     runs-on: "ubuntu-20.04"
     env:
       INVOKE_NAUTOBOT_PLUGIN_NORNIR_PYTHON_VER: "${{ matrix.python-version }}"

diff --git a/development/docker-compose.base.yml b/development/docker-compose.base.yml
@@ -21,8 +21,9 @@ services:
         condition: "service_started"
       db:
         condition: "service_healthy"
-    <<: *nautobot-build
-    <<: *nautobot-base
+    <<:
+      - *nautobot-base
+      - *nautobot-build
   worker:
     entrypoint:
       - "sh"

diff --git a/nautobot_plugin_nornir/__init__.py b/nautobot_plugin_nornir/__init__.py
@@ -1,10 +1,6 @@
 """Plugin declaration for nautobot_plugin_nornir."""
 # Metadata is inherited from Nautobot. If not including Nautobot in the environment, this should be added
-try:
-    from importlib import metadata
-except ImportError:
-    # Python version < 3.8
-    import importlib_metadata as metadata
+from importlib import metadata
 
 __version__ = metadata.version(__name__)
 

diff --git a/nautobot_plugin_nornir/plugins/credentials/nautobot_orm.py b/nautobot_plugin_nornir/plugins/credentials/nautobot_orm.py
@@ -4,7 +4,7 @@
 class NautobotORMCredentials:
     """Abstract Credentials Class designed to work with Nautobot ORM."""
 
-    def get_device_creds(self, device):  # pylint: disable=unused-argument, no-self-use
+    def get_device_creds(self, device):  # pylint: disable=unused-argument
         """Return the credentials for a given device.
 
         Args:
@@ -17,7 +17,7 @@ def get_device_creds(self, device):  # pylint: disable=unused-argument, no-self-
         """
         return (None, None, None)
 
-    def get_group_creds(self, group_name):  # pylint: disable=unused-argument, no-self-use
+    def get_group_creds(self, group_name):  # pylint: disable=unused-argument
         """Return the credentials for a given group.
 
         Args: