Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTM: Deprecates Python 3.7 #143

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

Kircheneer
Copy link

The tight pin on importlib-metadata is causing some issues. Since its only necessary for the EOL'd Python 3.7, this PR deprecates Python 3.7 and removes the dependency.

@Kircheneer Kircheneer self-assigned this Mar 13, 2024
@Kircheneer Kircheneer requested a review from jeffkala as a code owner March 13, 2024 12:03
@jeffkala
Copy link
Contributor

@Kircheneer can you also update pyproject.toml for black section: target-version = ['py37'] is still showing.

@itdependsnetworks
Copy link
Contributor

Do you mind doing this on nautobot core? Makes sense to defer that decision to them and we should align with their decision.

@glennmatthews
Copy link

glennmatthews commented Mar 13, 2024

Core already dropped python 3.7 support and removed importlib-metadata - nautobot/nautobot#3554 and nautobot/nautobot#4118

@jeffkala
Copy link
Contributor

Will update this PR, also need to rework the CI pipeline files.

@itdependsnetworks itdependsnetworks merged commit 2dd5a7b into ltm-1.6 Mar 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants