Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Demo Job CLI Script #415

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Apr 4, 2024

Closes: NaN

What's Changed

  • Fixed passing env variables to run_command task.
  • Added script to run demo jobs from invoke nbshell command.

@snaselj snaselj self-assigned this Apr 4, 2024
@snaselj snaselj changed the base branch from develop to u/snaselj-napps-276-external-integrations April 4, 2024 09:05
@snaselj snaselj marked this pull request as ready for review April 4, 2024 09:07
@snaselj snaselj requested a review from a team as a code owner April 4, 2024 09:07
@snaselj
Copy link
Contributor Author

snaselj commented Apr 4, 2024

After approval, I'll backport tasks.py changes to cookiecutter template.

Copy link
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82
Copy link
Contributor

jdrew82 commented Apr 10, 2024

Please fix the tests and we can get this merged.

@snaselj
Copy link
Contributor Author

snaselj commented Apr 10, 2024

Merged with the latest develop to resolve conflicts. This PR is based on #398 , so this should be merged first and mentioned one later.

@jdrew82 jdrew82 merged commit cfbadc6 into u/snaselj-napps-276-external-integrations Apr 10, 2024
16 checks passed
@jdrew82 jdrew82 deleted the u/snaselj-napps-282-jobs-script branch April 10, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants