Merge pull request #79 from naymspace/feature/fix-has-many-through

Render modal even if its not open
naymspace · Jan 31, 2024 · 82f0756 · 82f0756
2 parents eaddb5d + aa9a8a0
commit 82f0756
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/lib/backpex/html/layout.ex b/lib/backpex/html/layout.ex
@@ -440,10 +440,13 @@ defmodule Backpex.HTML.Layout do
       |> assign(:classes, get_modal_classes(assigns))
 
     ~H"""
-    <div :if={@open} id="modal">
+    <div id="modal">
       <div
         id="modal-overlay"
-        class="animate-fade-in fixed inset-0 z-50 bg-gray-900 bg-opacity-30 transition-opacity"
+        class={[
+          "animate-fade-in fixed inset-0 z-50 bg-gray-900 bg-opacity-30 transition-opacity",
+          unless(@open, do: "hidden")
+        ]}
         aria-hidden="true"
       >
       </div>
@@ -458,9 +461,9 @@ defmodule Backpex.HTML.Layout do
       >
         <div
           class={@classes}
-          phx-click-away={hide_modal(@target, @close_event_name)}
-          phx-window-keydown={hide_modal(@target, @close_event_name)}
-          phx-key="escape"
+          phx-click-away={@open && hide_modal(@target, @close_event_name)}
+          phx-window-keydown={@open && hide_modal(@target, @close_event_name)}
+          phx-key={@open && "escape"}
         >
           <!-- Header -->
           <div class="border-b border-gray-100 px-5 py-3">