Render modal even if its not open #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had some strange behaviour in the
HasManyThroughfield that caused the linked values to reset when other form elements changed. This was the result of a change where we prevent the entire modal markup from rendering if it is not open. The way theHasManyThroughfield currently works is that it stores the current state in the form inputs of the modal. This means that the modal markup has to be rendered even if if the modal is not open.To prevent the Live View from crashing when certain keys are pressed when the modal is closed, we now conditionally assign these events based on the open state of the modal.
We should address this when reworking the
HasManyThroughfield.