Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index form does not update form value #534

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fix index form does not update form value #534

merged 3 commits into from
Aug 29, 2024

Conversation

Flo0807
Copy link
Collaborator

@Flo0807 Flo0807 commented Aug 22, 2024 •
edited
Loading

  • We will now update the form when the "update-field" index edit event is triggered
  • We extract the value for the index edit select from the form

This PR fixes a bug where the index edit select could display an incorrect state:

Bildschirmaufnahme.2024-08-22.um.11.33.34.mov

@Flo0807 Flo0807 marked this pull request as draft August 22, 2024 09:11
@Flo0807 Flo0807 added the bug Something isn't working label Aug 22, 2024
@Flo0807 Flo0807 requested a review from krns August 22, 2024 09:37
@Flo0807 Flo0807 marked this pull request as ready for review August 22, 2024 09:55
@Flo0807 Flo0807 added the breaking-change A breaking change label Aug 22, 2024
@krns krns merged commit 30e728f into develop Aug 29, 2024
6 checks passed
@krns krns deleted the feature/fix-index-select-shows-wrong-state branch August 29, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krns krns Awaiting requested review from krns

Assignees
No one assigned
Labels
breaking-change A breaking change bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flo0807 @krns