-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable profiling for ocaml version > 4.08.0 #18
Conversation
Sure I'd certainly accept these changes. |
Yes, that's a good idea. I added the case to the |
configure
Outdated
@@ -370,7 +370,7 @@ if test $enable_prof -eq 1 | |||
then | |||
echo -n "checking whether to enable profiling: " | |||
case "${overs}" in | |||
4.08.[1-9]*|4.09.*|4.[1-9]*) | |||
4.08.[1-9]*|4.09.*|4.[1-9]*|5*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing: could you make it [5-9]*|[1-9][0-9]*)
instead (for future-proofing — even if it's likely to be obsolete when we reach such versions of OCaml 😉 )?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😄
I'm trying to run
opam pin mlgmpidl git+https://github.com/nberth/mlgmpidl
, but it fails with the following error message.Can we add the
-disable-profiling
flag with filter{ocaml:version > "4.08.0"}
to the build step?