Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable profiling for ocaml version > 4.08.0 #18

Merged
merged 5 commits into from
Mar 1, 2023
Merged

Disable profiling for ocaml version > 4.08.0 #18

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
637f05b
Disable profiling for ocaml version > 4.08.0
nicokn Feb 26, 2023
a7b79ff
Add bigarray-compat dependency
nicokn Feb 26, 2023
3f68caf
Add missing version case to configure file
nicokn Feb 27, 2023
047446e
Add missing version case to configure file
nicokn Feb 27, 2023
55a0d88
Disable profiling for all future versions
nicokn Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ if test $enable_prof -eq 1
then
echo -n "checking whether to enable profiling: "
case "${overs}" in
4.08.[1-9]*|4.09.*|4.[1-9]*)
4.08.[1-9]*|4.09.*|4.[1-9]*|5*)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing: could you make it [5-9]*|[1-9][0-9]*) instead (for future-proofing — even if it's likely to be obsolete when we reach such versions of OCaml 😉 )?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 😀

echo "only available up to OCaml 4.08.0 (<= ${overs})";
enable_prof=0;;
*)
Expand Down
1 change: 1 addition & 0 deletions opam/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ depends: [
"conf-gmp"
"conf-mpfr"
"conf-perl" {build}
"bigarray-compat"
]
conflicts: [
"mlgmp"
Expand Down