Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Remove parenthesis when using raise keyword #1

Closed
knocte opened this issue Feb 21, 2022 · 0 comments
Closed

[Feature request] Remove parenthesis when using raise keyword #1

knocte opened this issue Feb 21, 2022 · 0 comments

Comments

@knocte
Copy link
Member

knocte commented Feb 21, 2022

Test1:

raise(InvalidPassword)

should become:

raise InvalidPassword

Test2:

raise InvalidPassword

should become (same):

raise InvalidPassword

(should not change)


Test3:

raise(AddressWithInvalidChecksum None)

should become:

raise <| AddressWithInvalidChecksum None

Test4:

raise(Exception("foo"))

should become:

raise <| Exception("foo")

Test5:

raise(Exception(ex.ToString(), (ex.InnerException)))

should become:

raise <| Exception(ex.ToString(), (ex.InnerException))
knocte added a commit to nblockchain/geewallet that referenced this issue Feb 21, 2022
Command to install: dotnet tool install --global fantomless-tool --version 4.5.12.5
Command to run: fantomless --recurse src/GWallet.Backend/
(or $HOME/.dotnet/tools/fantomless in case of running from CI)

Fantomas/fantomless bugs that geewallet would benefit from, if fixed:

* fsprojects/fantomas#1901

* fsprojects/fantomas#1469

* fsprojects/fantomas#712

* fsprojects/fantomas#684

* fsprojects/fantomas#815

* fsprojects/fantomas#1442

* fsprojects/fantomas#1233

* fsprojects/fantomas#1223

* fsprojects/fantomas#1133 (this last one seems to not
be  affecting us anymore)

* fsprojects/fantomas#2111

* nblockchain/fantomless#1

TODO:
* finish this list above from the commit messages in
experiments/fantomas branch
janus added a commit to janus/fantomas that referenced this issue Feb 22, 2022
@knocte knocte closed this as completed in 9a7667e Feb 24, 2022
janus added a commit to janus/fantomas that referenced this issue Mar 29, 2022
knocte pushed a commit that referenced this issue Mar 29, 2022
knocte pushed a commit that referenced this issue Mar 29, 2022
knocte pushed a commit that referenced this issue Mar 30, 2022
knocte pushed a commit that referenced this issue Mar 30, 2022
knocte pushed a commit that referenced this issue Mar 31, 2022
knocte pushed a commit that referenced this issue Mar 31, 2022
knocte pushed a commit that referenced this issue Mar 31, 2022
knocte pushed a commit that referenced this issue Apr 1, 2022
knocte pushed a commit that referenced this issue Apr 7, 2022
knocte pushed a commit that referenced this issue Apr 7, 2022
knocte pushed a commit that referenced this issue Apr 7, 2022
knocte pushed a commit that referenced this issue Apr 7, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 15, 2022
knocte pushed a commit that referenced this issue Apr 19, 2022
knocte pushed a commit that referenced this issue Apr 20, 2022
knocte pushed a commit that referenced this issue May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant