Frontend.Console: ask confirmation from funder #183
Conversation
parhamsaremi
force-pushed
the
channel-confirm
branch
2 times, most recently
from
9b893d4
to
f9b6b34
Compare
|
@aarani please review |
|
I don't like this error "funder didn't confirm to lock the funding!". geewallet user doesn't know what funder or fundee means. |
Do you have any suggestions for the replacement? 🤔 |
@aarani ping |
|
@parhamsaremi UI messages are mostly @knocte 's area |
But I pinged you, so I want to know what's your best suggestion first, then I'll improve on that. |
|
BTW this PR needs to be rebased (to eliminate the red CI), I believe. |
@parhamsaremi @knocte "Funding is confirmed, awaiting locking" smth like that |
|
What does "locking" mean exactly? |
Channel Locking, funding_locked. |
What does that mean, for the layman? |
Not sure, we always call it locking, even geewallet ui says locking |
|
Yeah I know we already have some strings that use that term, but I was never convinced about them so I'm taking this opportunity to review this. @aarani how do other wallets call this? @parhamsaremi why is CI still red? |
Unfortunately idk, according to my experience with muun, they completely hide the channel making process. |
Sorry I was focused on other tasks I'll rebase now. Did you reach a final decision about the message? |
parhamsaremi
force-pushed
the
channel-confirm
branch
from
f9b6b34
to
7484570
Compare
Fix cherry-picked from stable branch: CI on master branch caught this[1]: ``` Unhandled Exception: System.AggregateException: One or more errors occurred. (Some problem when connecting to 'api.mycryptoapi.com/eth') ---> System.Exception: Some problem when connecting to 'api.mycryptoapi.com/eth' ---> System.Exception: RpcResponseException with RpcError Code <-32002> and Message 'rejected due to project ID settings' (rejected due to project ID settings) ---> JsonRpcSharp.Client.RpcResponseException: rejected due to project ID settings at JsonRpcSharp.Client.ClientBase.HandleRpcError (JsonRpcSharp.Client.RpcMessages.RpcResponseMessage response) [0x00033] in <4c31088b87e449d8935ce2e038670d08>:0 at JsonRpcSharp.Client.ClientBase.SendInnerRequestAsync[T] (JsonRpcSharp.Client.RpcMessages.RpcRequestMessage reqMsg, System.String route, System.Threading.CancellationToken cancellationToken) [0x00089] in <4c31088b87e449d8935ce2e038670d08>:0 at JsonRpcSharp.Client.ClientBase.SendInnerRequestAsync[T] (JsonRpcSharp.Client.RpcRequest request, System.String route, System.Threading.CancellationToken cancellationToken) [0x000a3] in <4c31088b87e449d8935ce2e038670d08>:0 at JsonRpcSharp.Client.ClientBase.SendRequestAsync[T] (JsonRpcSharp.Client.RpcRequest request, System.String route, System.Threading.CancellationToken cancellationToken) [0x00127] in <4c31088b87e449d8935ce2e038670d08>:0 --- End of inner exception stack trace --- at GWallet.Backend.Ether.Server.MaybeRethrowRpcResponseException (System.Exception ex) [0x001a9] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:224 at GWallet.Backend.Ether.Server.ReworkException (System.Exception ex) [0x0000e] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:299 at GWallet.Backend.Ether.Server+HandlePossibleEtherFailures@387-6[R].Invoke (System.Exception _arg2) [0x00002] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:392 at GWallet.Backend.Ether.Server+HandlePossibleEtherFailures@387-8[R].Invoke (System.Exception exn) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:387 at GWallet.Backend.Ether.Server+HandlePossibleEtherFailures@387-10[R].Invoke (System.Exception edi) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:387 at Microsoft.FSharp.Control.AsyncPrimitives.CallFilterThenInvoke[T] (Microsoft.FSharp.Control.AsyncActivation`1[T] ctxt, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] catchFilter, System.Runtime.ExceptionServices.ExceptionDispatchInfo edi) [0x00005] in E:\A\_work\130\s\src\fsharp\FSharp.Core\async.fs:435 at Microsoft.FSharp.Control.Trampoline.Execute (Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] firstAction) [0x00020] in E:\A\_work\130\s\src\fsharp\FSharp.Core\async.fs:109 --- End of inner exception stack trace --- at GWallet.Backend.Ether.Server+Web3ServerToRetrievalFunc@406-2[R].Invoke (System.Exception _arg3) [0x00060] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:415 at GWallet.Backend.Ether.Server+Web3ServerToRetrievalFunc@406-5[R].Invoke (System.Exception exn) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:406 at GWallet.Backend.Ether.Server+Web3ServerToRetrievalFunc@406-7[R].Invoke (System.Exception edi) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:406 at Microsoft.FSharp.Control.AsyncPrimitives.CallFilterThenInvoke[T] (Microsoft.FSharp.Control.AsyncActivation`1[T] ctxt, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] catchFilter, System.Runtime.ExceptionServices.ExceptionDispatchInfo edi) [0x00005] in E:\A\_work\130\s\src\fsharp\FSharp.Core\async.fs:435 at Microsoft.FSharp.Control.Trampoline.Execute (Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] firstAction) [0x00020] in E:\A\_work\130\s\src\fsharp\FSharp.Core\async.fs:109 --- End of stack trace from previous location where exception was thrown --- at GWallet.Backend.FSharpUtil.ReRaise (System.Exception ex) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/FSharpUtil.fs:206 ... ``` [1] https://github.com/nblockchain/geewallet/actions/runs/3507005645/jobs/5874411684
Previously we only asked the funder to press a key to continue the process. But now we ask the funder to state if he wants to continue or not.
parhamsaremi
force-pushed
the
channel-confirm
branch
from
7484570
to
31cee49
Compare
Previously we only asked the funder to press a key to continue the process. But now we ask the funder to state if he wants to continue or not.