Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend.Console: ask confirmation from funder #183

Open
wants to merge 2 commits into
base: lightning
Choose a base branch
from
Open

Frontend.Console: ask confirmation from funder #183

wants to merge 2 commits into from

Commits on Nov 22, 2022

  1. Backend/Ether: catch/retry new -32002 error code 

    Fix cherry-picked from stable branch:

CI on master branch caught this[1]:

```
Unhandled Exception:
System.AggregateException: One or more errors occurred. (Some problem when connecting to 'api.mycryptoapi.com/eth') ---> System.Exception: Some problem when connecting to 'api.mycryptoapi.com/eth' ---> System.Exception: RpcResponseException with RpcError Code <-32002> and Message 'rejected due to project ID settings' (rejected due to project ID settings) ---> JsonRpcSharp.Client.RpcResponseException: rejected due to project ID settings
  at JsonRpcSharp.Client.ClientBase.HandleRpcError (JsonRpcSharp.Client.RpcMessages.RpcResponseMessage response) [0x00033] in <4c31088b87e449d8935ce2e038670d08>:0
  at JsonRpcSharp.Client.ClientBase.SendInnerRequestAsync[T] (JsonRpcSharp.Client.RpcMessages.RpcRequestMessage reqMsg, System.String route, System.Threading.CancellationToken cancellationToken) [0x00089] in <4c31088b87e449d8935ce2e038670d08>:0
  at JsonRpcSharp.Client.ClientBase.SendInnerRequestAsync[T] (JsonRpcSharp.Client.RpcRequest request, System.String route, System.Threading.CancellationToken cancellationToken) [0x000a3] in <4c31088b87e449d8935ce2e038670d08>:0
  at JsonRpcSharp.Client.ClientBase.SendRequestAsync[T] (JsonRpcSharp.Client.RpcRequest request, System.String route, System.Threading.CancellationToken cancellationToken) [0x00127] in <4c31088b87e449d8935ce2e038670d08>:0
   --- End of inner exception stack trace ---
  at GWallet.Backend.Ether.Server.MaybeRethrowRpcResponseException (System.Exception ex) [0x001a9] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:224
  at GWallet.Backend.Ether.Server.ReworkException (System.Exception ex) [0x0000e] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:299
  at GWallet.Backend.Ether.Server+HandlePossibleEtherFailures@387-6[R].Invoke (System.Exception _arg2) [0x00002] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:392
  at GWallet.Backend.Ether.Server+HandlePossibleEtherFailures@387-8[R].Invoke (System.Exception exn) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:387
  at GWallet.Backend.Ether.Server+HandlePossibleEtherFailures@387-10[R].Invoke (System.Exception edi) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:387
  at Microsoft.FSharp.Control.AsyncPrimitives.CallFilterThenInvoke[T] (Microsoft.FSharp.Control.AsyncActivation`1[T] ctxt, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] catchFilter, System.Runtime.ExceptionServices.ExceptionDispatchInfo edi) [0x00005] in E:\A\_work\130\s\src\fsharp\FSharp.Core\async.fs:435
  at Microsoft.FSharp.Control.Trampoline.Execute (Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] firstAction) [0x00020] in E:\A\_work\130\s\src\fsharp\FSharp.Core\async.fs:109
   --- End of inner exception stack trace ---
  at GWallet.Backend.Ether.Server+Web3ServerToRetrievalFunc@406-2[R].Invoke (System.Exception _arg3) [0x00060] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:415
  at GWallet.Backend.Ether.Server+Web3ServerToRetrievalFunc@406-5[R].Invoke (System.Exception exn) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:406
  at GWallet.Backend.Ether.Server+Web3ServerToRetrievalFunc@406-7[R].Invoke (System.Exception edi) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/Ether/EtherServer.fs:406
  at Microsoft.FSharp.Control.AsyncPrimitives.CallFilterThenInvoke[T] (Microsoft.FSharp.Control.AsyncActivation`1[T] ctxt, Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] catchFilter, System.Runtime.ExceptionServices.ExceptionDispatchInfo edi) [0x00005] in E:\A\_work\130\s\src\fsharp\FSharp.Core\async.fs:435
  at Microsoft.FSharp.Control.Trampoline.Execute (Microsoft.FSharp.Core.FSharpFunc`2[T,TResult] firstAction) [0x00020] in E:\A\_work\130\s\src\fsharp\FSharp.Core\async.fs:109
--- End of stack trace from previous location where exception was thrown ---

  at GWallet.Backend.FSharpUtil.ReRaise (System.Exception ex) [0x00000] in /Users/runner/work/geewallet/geewallet/src/GWallet.Backend/FSharpUtil.fs:206
...
```

[1] https://github.com/nblockchain/geewallet/actions/runs/3507005645/jobs/5874411684
    @knocte
    knocte committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    eff9112 View commit details
    Browse the repository at this point in the history

  2. Frontend.Console: ask confirmation from funder 

    Previously we only asked the funder to press a key to continue
the process. But now we ask the funder to state if he wants to
continue or not.
    @parhamsaremi
    parhamsaremi committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    31cee49 View commit details
    Browse the repository at this point in the history