[NOT TESTED] Backend,Frontend,Tests: rm txDetail from SignedTx #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supersedes #224 |
|
I'm afraid this needs to be rebased. |
aarani
force-pushed
the
updateNeth-rebased
branch
2 times, most recently
from
5e9e7c6
to
27543c0
Compare
ETC was previously marked as non-centeralized[1], this commit removes this flag since it's no longer needed. [1] 9392215
This commit updates Nethereum to latest version to support extracting token transfer amount from the raw tx created when sending (hot-storage) or signing (cold-storage). It's noteworthy to say that Web3 no longer accepts a timeout as an argument. Nethereum now supports different types of transactions like those that support EIP-1559, at this moment there's no clear benefit for migrating especially given the fact that it will causes incompatiblity with ETC so we will continue to use Legacy types for now.
This commit removes the redundant proposal and metadata from the SignedTransaction type.
aarani
force-pushed
the
updateNeth-rebased
branch
from
5e9e7c6
to
dc66da1
Compare
knocte
reviewed
Feb 12, 2024
| } | ||
| ] | ||
| }, | ||
| "Cache": { |
There was a problem hiding this comment.
@aarani this looks wrong, why are you removing the Cache?
knocte
force-pushed
the
master
branch
2 times, most recently
from
b841302
to
ccb1641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.