Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOT TESTED] Backend,Frontend,Tests: rm txDetail from SignedTx #238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[NOT TESTED] Backend,Frontend,Tests: rm txDetail from SignedTx #238

wants to merge 3 commits into from

Commits on Oct 31, 2023

  1. Backend/Ether: rm etcIsMomentarilyCentralized flag 

    ETC was previously marked as non-centeralized[1], this commit
removes this flag since it's no longer needed.

[1] 9392215
    @aarani
    aarani committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    dc66da1 View commit details
    Browse the repository at this point in the history

  2. Backend: update Nethereum to latest version 

    This commit updates Nethereum to latest version to support
extracting token transfer amount from the raw tx created when
sending (hot-storage) or signing (cold-storage).

It's noteworthy to say that Web3 no longer accepts a timeout
as an argument.

Nethereum now supports different types of transactions like
those that support EIP-1559, at this moment there's no
clear benefit for migrating especially given the fact that
it will causes incompatiblity with ETC so we will continue
to use Legacy types for now.
    @aarani
    aarani committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    10b5fd9 View commit details
    Browse the repository at this point in the history

  3. Backend,Frontend,Tests: rm txDetail from SignedTx 

    This commit removes the redundant proposal and metadata
from the SignedTransaction type.
    @aarani
    aarani committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    cd9e2e8 View commit details
    Browse the repository at this point in the history