added secp256k1 algo for key generation #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,6 +49,7 @@ export class PublicKey extends Assignable { | |||
|
|
|||
| static fromString(encodedKey: string): PublicKey { | |||
| const parts = encodedKey.split(':'); | |||
| //TODO: ask what to do in this case | |||
There was a problem hiding this comment.
Need advice on how to deal with this
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added algo secp256k1 for key generation process.
It uses https://www.npmjs.com/package/secp256k1 npm module; private key generates from random bytes using core nodejs lib 'crypto', public key generation, signing and verifying provided by secp256k1 module;
This feature will add an option to generate keys using new algorithm