Add secp256k1 support #810
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Mike, looks like my master rebase messed up the imports 😊 |
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days. |
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days. |
|
Bumping a bit, as this is a pretty important feature and without it, folks are not able to use one of the two key types available in NEAR. |
|
Closing in favor of #985 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the secp256k1 curve. It's based off #780, which gets pretty close. @mikedotexe asked us to take a look at the js implementation after adding secp support in the swift library here.