This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
Added the ability to optionally set the keyPath and networkId for localnet #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenKurrek
changed the title
BenKurrek
changed the title
…ossible collisions
volovyks
reviewed
Nov 24, 2021
There was a problem hiding this comment.
@BenKurrek LGTM, but let's keep naming more explicit.
NEAR_CLI_LOCALNET_NETWORK_ID and NEAR_CLI_LOCALNET_KEY_PATH will be more explanatory + we will not have problems in the future if we will decide to add such constants to other networks.
volovyks
approved these changes
Nov 24, 2021
|
Thank you for the contribution @BenKurrek ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #884
I've added the option to set the keyPath and networkId for localnet.