fix: rm-serde-arbitrary-precision-feat #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
|
@frol This is ready to be reviewed. |
|
@shariffdev Why was it used in the first place? Does it break anything when this feature is dropped? cc @ChaoticTempest |
I did not find any example that broke without the feature. Please advise @ChaoticTempest |
|
I have pushed a small fix, everything is looking good now! |
frol
reviewed
Sep 9, 2023
examples/src/ref_finance.rs
Outdated
Comment on lines
72
to
75
| .args_json(json!({ | ||
| "owner_id": owner.id(), | ||
| "total_supply": parse_near!("1,000,000,000 N"), | ||
| "total_supply": parse_near!("1,000,000,000 N").to_string(), | ||
| })) |
There was a problem hiding this comment.
wrap.near contract new method does not expect any arguments O_o
Let's remove args_json completely, and test again.
frol
approved these changes
Sep 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279
The
arbitrary_precisionfeature is removed from serde_json in the Cargo.toml