Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm-serde-arbitrary-precision-feat #287

Merged
merged 6 commits into from Sep 9, 2023
Merged

fix: rm-serde-arbitrary-precision-feat #287

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5cb39db
fix: rm-serde-arbitrary-precision-feat
Aug 8, 2023
8a03ced
Merge branch 'main' into fix/rm-serde-arbitrary-precision-feat
Sep 1, 2023
f25f9ec
Merge branch 'main' into fix/rm-serde-arbitrary-precision-feat
Sep 9, 2023
b356ccd
fix: ref-finance example
Sep 9, 2023
72d66de
Merge branch 'main' into fix/rm-serde-arbitrary-precision-feat
Sep 9, 2023
c6a6987
rm args
Sep 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ maplit = "1.0"
near-units = "0.2.0"
serde = "1.0"
serde_with = "1"
# arbitrary_precision enabled for u128 types that workspaces requires for Balance types
serde_json = { version = "1.0", features = ["arbitrary_precision"] }
serde_json = { version = "1.0" }
tokio = { version = "1.10.0", features = ["full"] }
tracing = "0.1"
tracing-subscriber = { version = "0.3.5", features = ["env-filter"] }
Expand Down
2 changes: 1 addition & 1 deletion examples/src/ref_finance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ async fn create_wnear(owner: &Account, worker: &Worker<Sandbox>) -> anyhow::Resu
.call(wnear.id(), "new")
.args_json(json!({
"owner_id": owner.id(),
"total_supply": parse_near!("1,000,000,000 N"),
"total_supply": parse_near!("1,000,000,000 N").to_string(),
}))
Copy link
Collaborator

@frol frol Sep 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap.near contract new method does not expect any arguments O_o

https://github.com/near/core-contracts/blob/3f3170fce91ff4d8c6ee9d15683f2d4dfe1275cf/w-near/src/lib.rs#L36

Let's remove args_json completely, and test again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let me try!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works okay!

.transact()
.await?
Expand Down