wasmtime: add caching of executables and artifacts #11532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
force-pushed
the
implements-wasmtime-caching
branch
from
9feb04b to
0c434e6
Compare
This largely mirrors the code in near_vm_runner module. I heard some people pondering what it would be like to use a higher quality backend. Outside LLVM, Cranelift is by far the next in line in produced code quality. Since we already have wasmtime in place, might as well wire it up completely for a full experience.
nagisa
force-pushed
the
implements-wasmtime-caching
branch
from
0c434e6 to
aeb4c6d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11532 +/- ##
==========================================
- Coverage 71.47% 71.47% -0.01%
==========================================
Files 788 788
Lines 160774 160854 +80
Branches 160774 160854 +80
==========================================
+ Hits 114919 114976 +57
- Misses 40842 40856 +14
- Partials 5013 5022 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This largely mirrors the code in near_vm_runner module. I heard some
people pondering what it would be like to use a higher quality backend.
Outside LLVM, Cranelift is by far the next in line in produced code
quality. Since we already have wasmtime in place, might as well wire it
up completely for a full experience.
Based on top of #11529
Part of #11319