wasmtime: remove lightbeam support code #11529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightbeam backend has been removed from wasmtime all the way back in 2021. The supporting code we have here won't build, and we don't test it either.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11529 +/- ##
==========================================
- Coverage 71.37% 71.36% -0.01%
==========================================
Files 790 790
Lines 160086 160086
Branches 160086 160086
==========================================
- Hits 114256 114243 -13
- Misses 40857 40867 +10
- Partials 4973 4976 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akhi3030
approved these changes
Jun 13, 2024
Ekleog-NEAR
approved these changes
Jun 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 19, 2024
This largely mirrors the code in near_vm_runner module. I heard some people pondering what it would be like to use a higher quality backend. Outside LLVM, Cranelift is by far the next in line in produced code quality. Since we already have wasmtime in place, might as well wire it up completely for a full experience. Based on top of #11529 Part of #11319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lightbeam backend has been removed from wasmtime all the way back in 2021. The supporting code we have here won't build, and we don't test it either.
bytecodealliance/wasmtime#3390