vmlogic: maintain memory by a Box #11614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wacban
approved these changes
Jun 19, 2024
This is a part of an effort to drop the lifetime from the `VMLogic` structure in order to make it more straightforward to have it live for a longer duration alongside the instance and not force our hand in pretty much "create-execute contract-drop" flow.
nagisa
force-pushed
the
delifetimes-vmlogic-some-0
branch
from
f2a0b40
to
5bfbe8a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11614 +/- ##
==========================================
+ Coverage 71.46% 71.48% +0.02%
==========================================
Files 788 788
Lines 160854 160854
Branches 160854 160854
==========================================
+ Hits 114947 114992 +45
+ Misses 40887 40843 -44
+ Partials 5020 5019 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
…11615) `VMLogic` containing a lifetime makes it difficult to have it live for any longer than a short sequence of `instantiate-link-run` and is one of the reasons why we're forced to have some unsafe code in our linking code. This refactor replaces some of the reference fields with `Arc`s, `Box`es, etc. This is not a complete refactor, I intend to do the remainder as a follow-up. Based on #11614 Part of #11319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of an effort to drop the lifetime from the
VMLogicstructure in order to make it more straightforward to have it live for a longer duration alongside the instance and not force our hand in pretty much "create-execute contract-drop" flow.Part of #11319