refactor: replace some references with owned structures in VMLogic #11615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11615 +/- ##
==========================================
- Coverage 71.48% 71.45% -0.03%
==========================================
Files 788 788
Lines 160835 160921 +86
Branches 160835 160921 +86
==========================================
+ Hits 114968 114993 +25
- Misses 40850 40901 +51
- Partials 5017 5027 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tayfunelmas
approved these changes
Jun 20, 2024
Not a refactor that makes things pretty, especially as it pertains to the tests which willy-nilly mutate fields within these configs. But in actual production code this makes a lot of sense -- we have a single store of configurations that get loaded at startup and then proliferated across the codebase. Having these be `Arc` is a minimal expense and having the configs be a reference-counted pointers makes it much more straightforward to keep these configurations wherever they belong without unnecessary cloning of the underlying data or introducing nasty lifetimes as was the case with `VMLogic`. (`VMLogic` still has a lifetime, but it no longer is because of configs)
nagisa
force-pushed
the
delifetimes-vmlogic-some
branch
from
1f3071c
to
4851fce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMLogiccontaining a lifetime makes it difficult to have it live for any longer than a short sequence ofinstantiate-link-runand is one of the reasons why we're forced to have some unsafe code in our linking code.This refactor replaces some of the reference fields with
Arcs,Boxes, etc. This is not a complete refactor, I intend to do the remainder as a follow-up.Based on #11614
Part of #11319