Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback #6713 due to possibility of dropping transactions received right before an epoch boundary. #6827

Merged
merged 5 commits into from
May 19, 2022

Conversation

nikurt
Copy link
Contributor

@nikurt nikurt commented May 18, 2022

No description provided.

@nikurt nikurt requested a review from a team as a code owner May 18, 2022 14:07
@nikurt nikurt requested a review from jakmeier May 18, 2022 14:07
Copy link
Contributor

@jakmeier jakmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like too little context. Could you write down somewhere (GH issue, comment, this PR description, or previous PR) why the current solution does not work? I can sort of guess it from the title but as someone unfamiliar with this code area, I can't say I understand the details. And hence I cannot review it with good faith.

@near-bulldozer near-bulldozer bot merged commit 0b5b31b into master May 19, 2022
@near-bulldozer near-bulldozer bot deleted the nikurt-txpool-rollback branch May 19, 2022 16:17
@nikurt
Copy link
Contributor Author

nikurt commented May 19, 2022

@jakmeier That's a fair question. I have a more verbose issue description in https://docs.google.com/document/d/1tZvXyaQeFSMUY-IyFtU_vjkkMiKco1_nLRtGzzBERMo/edit#bookmark=id.k2s0x3ipu5bt

The root cause of the issue is that a transaction is forwarded either to:

  • chunk producers of the next 4 blocks in the current epoch
  • chunk producers of the next 4 blocks in the next epoch

The current solution doesn't work if:
a) a node forwards transaction to the next epoch chunk producers, but
b) those chunk producers are not validators in the current epoch

because the forwarded transactions will simply get dropped.

The previous solution worked well enough in practice and rolling back to it should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants