fix: allow tla-account creation on sandbox #9693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
nagisa
reviewed
Oct 17, 2023
| @@ -36,6 +36,7 @@ static CONFIG_DIFFS: &[(ProtocolVersion, &str)] = &[ | |||
| (61, include_config!("61.yaml")), | |||
| (62, include_config!("62.yaml")), | |||
| (63, include_config!("63.yaml")), | |||
| #[cfg(not(feature = "sandbox"))] | |||
There was a problem hiding this comment.
This doesn’t seem like a correct approach. What if somebody adds another parameter change to this version, even if in the future releases of the protocol? This is also a departure from how sandbox functionality changes have been implemented in the past, which is feature gating specific areas of the implementation, rather than configuration.
|
Thanks @nagisa for the feedback. I'll close this meanwhile in favour of a better solution that's to come. |
ghost
closed this
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEP 492 was stabilised #9658 which breaks existing tests for
near-workspacesThe condition can be loosened for sandbox, suggested here #9665 (comment)