Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow tla-account creation on sandbox #9693

Closed
wants to merge 1 commit into from
Closed

fix: allow tla-account creation on sandbox #9693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/primitives/src/runtime/config_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ static CONFIG_DIFFS: &[(ProtocolVersion, &str)] = &[
(61, include_config!("61.yaml")),
(62, include_config!("62.yaml")),
(63, include_config!("63.yaml")),
#[cfg(not(feature = "sandbox"))]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t seem like a correct approach. What if somebody adds another parameter change to this version, even if in the future releases of the protocol? This is also a departure from how sandbox functionality changes have been implemented in the past, which is feature gating specific areas of the implementation, rather than configuration.

(64, include_config!("64.yaml")),
(129, include_config!("129.yaml")),
];
Expand Down
7 changes: 6 additions & 1 deletion integration-tests/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,12 @@ nightly_protocol = [
"node-runtime/nightly_protocol",
"testlib/nightly_protocol",
]
sandbox = ["near-chain/sandbox", "node-runtime/sandbox", "near-client/sandbox"]
sandbox = [
"near-chain/sandbox",
"node-runtime/sandbox",
"near-client/sandbox",
"near-primitives/sandbox",
]
no_cache = ["nearcore/no_cache"]
calimero_zero_storage = []
new_epoch_sync = ["nearcore/new_epoch_sync"]
2 changes: 1 addition & 1 deletion runtime/runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ no_cache = [
"near-store/no_cache",
]

sandbox = ["near-vm-runner/sandbox"]
sandbox = ["near-vm-runner/sandbox", "near-primitives/sandbox"]

[dev-dependencies]
assert_matches.workspace = true
Expand Down
1 change: 1 addition & 0 deletions tools/state-viewer/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ sandbox = [
"node-runtime/sandbox",
"near-chain/sandbox",
"near-client/sandbox",
"near-primitives/sandbox",
]
nightly = [
"nightly_protocol",
Expand Down