Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add My Near Wallet to Selector #288

Closed
wants to merge 2 commits into from
Closed

Conversation

gutsyphilip
Copy link
Contributor

@gutsyphilip gutsyphilip commented May 16, 2022

Description

Since we are migrating the NEAR Wallet to the My Near Wallet domain(mynearwallet.com), we need to add a new option to the selector for the new wallet.

The goal is to eventually deprecate the Near wallet domain(wallet.near.org) once migration is completed.

image

Closes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change. This type of change is the main reason for the PR.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

Breaking changes

  • BREAKING CHANGE - SPECIFY: _______
  • NO BREAKING CHANGE - this PR doesn't contain any breaking changes and it's backwards compatible

@lewis-sqa lewis-sqa mentioned this pull request May 25, 2022
14 tasks
@lewis-sqa
Copy link
Contributor

Hey @gutsyphilip, thanks for raising this PR!

We're in the process of releasing a new major version (currently on the dev branch) of the library that means the structure of a wallet has changed quite significantly. Since this new version is only a matter of days away, we would prefer if the changes were made against dev.

I've raised a POC variation of your work here that wraps the existing NEAR Wallet implementation to reduce code duplication as it appears My NEAR Wallet functions 1:1 with NEAR Wallet with only the walletUrl that changes?

I noticed My NEAR Wallet lacks a betanet variation but includes a staging environment. To avoid confusion, I've omitted this link and forced the dApp developer to explicitly define the walletUrl for networks that aren't mainnet or testnet.

@lewis-sqa lewis-sqa closed this Jul 1, 2022
@AmmarHumackicSQA AmmarHumackicSQA deleted the feat/my-near-wallet branch August 30, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants