Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for My NEAR Wallet #301

Merged
merged 17 commits into from
May 27, 2022
Merged

feat: Support for My NEAR Wallet #301

merged 17 commits into from
May 27, 2022

Conversation

lewis-sqa
Copy link
Contributor

@lewis-sqa lewis-sqa commented May 25, 2022

Description

  • Sightly different approach to Feat: Add My Near Wallet to Selector #288. This instead wraps the existing NEAR Wallet implementation while overriding the important differences (id, metadata & walletUrl). Since My NEAR Wallet will become the supported wallet going forward, we've switched around the wrapping so NEAR Wallet wraps the new My NEAR Wallet implementation.
  • Added support for accessing Options during wallet module setup.
  • Simplified ExtraOptions interfaces for WalletConnect and My NEAR Wallet.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Type of change.

  • FIX - a PR of this type patches a bug.
  • FEATURE - a PR of this type introduces a new feature.
  • BUILD - a PR of this type introduces build changes.
  • CI - a PR of this type introduces CI changes.
  • DOCS - a PR of this type introduces DOCS improvement.
  • STYLE - a PR of this type introduces style changes.
  • REFACTOR - a PR of this type introduces refactoring.
  • PERFORMANCE - a PR of this type introduces performance changes.
  • TEST - a PR of this type adds more tests.
  • CHORE - a PR introduces other changes than the specified above.

@lewis-sqa lewis-sqa self-assigned this May 25, 2022
@lewis-sqa lewis-sqa changed the title SQAC-158: Support for My NEAR Wallet (POC) SQAC-158: Support for My NEAR Wallet May 27, 2022
@lewis-sqa lewis-sqa marked this pull request as ready for review May 27, 2022 07:59
@github-actions github-actions bot changed the title SQAC-158: Support for My NEAR Wallet feat: Support for My NEAR Wallet May 27, 2022
@lewis-sqa lewis-sqa merged commit 4dee794 into dev May 27, 2022
@lewis-sqa lewis-sqa deleted the SQAC-158/my-near-wallet branch May 27, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants