-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newton-Krylov solver #114
Merged
Newton-Krylov solver #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d newton_opts. Updated tests.
…d on the Newton iteration count.
…fo to shape assertion checks for better diagnostics. Deployed change to LightKrylov
I'll try to add the FTLEs in the example before the merge. |
…on with reference for Roessler.
Ready for merge. |
loiseaujc
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty good to me overall. Just a set of minor changes (in my opinion, but you may argue otherwise) and it'll be ready to merge into dev
.
loiseaujc
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a basic Newton-Krylov root-finding algorithm for fixed points and periodic orbits.
Algorithmic features:
abstract_linear_solver
that allows the tolerances chosen in the Newton iteration to be broadcast to the concrete solver used.contant_atol
, which always returns the absolute tolerance for the Newton iteration, anddynamic_tol
, which instead dynamically adapts the solver tolerances to 10% of the current residual norm which may accelerate computations.Integration:
abstract_dynamical_system
andabstract_jacobian
are defined. Theabstract_dynamical_system
contains and instance ofabstract_jacobian
(derived fromabstract_linop
), which itself contains anabstract_vector
corresponding to the current estimate of the fixed point (or initial point of the periodic orbit) around which the jacobian is evaluated.abstract_dynamical_system
also exposes an interface for the user-defined function to evaluate the residual of the function of which we seek a root.sp
anddp
.verbosity
flags in favor of a full adoption of the logger framework throughout the project.*.fypp
framework.Roessler example
rklib
for time integration, includes examples of all the features of the solver.Possible extensions:
TestUtils.f90
.